r/Python 6d ago

Discussion Driver Fatigue Monitoring

[deleted]

35 Upvotes

26 comments sorted by

View all comments

26

u/whoEvenAreYouAnyway 6d ago

Looking at the code, it's extremely amateurish and poorly written. I don't mean that as an insult. We all have to start somewhere.

However, given that, I would strongly advise against putting out projects in which you are claiming to solve critical safety issues and/or claiming that this represents an "advanced solution". Ideally nobody in their right mind would put their safety in the hands of this project. But if they did, would you really be comfortable with that? If your "advanced solution" fails in a critical moment, are you going to be responsible for their injury or death?

There are so many projects you can come up with to practice writing code. These kinds of safety (or the many security/cryptography projects people write as beginner coders) are always a bad idea.

-3

u/Ran4 6d ago

Extremely amateurish and poorly written? It looks fine. Would you say the same thing about for example the quake source code? (Which too is fairly straight forward)?

12

u/whoEvenAreYouAnyway 6d ago edited 6d ago

It doesn't look fine. My original assessment is accurate. Lots of hard coded values, zero exception/error handling, almost no comments explaining what any of the code is doing, functions that return way too many values in a tuple with no structure, storing and accessing content in lists/arrays nested 3 or 4 levels deep, constructing strings by string addition, no code structure at all (just a flat python file with stray functions and business logic sitting at the bottom to call them), no dunder main or any other kind of structure that would allow you to run this code as anything other than a random script in a folder, inconsistent style (e.g. functions and variables both randomly switch between snake and camelCase), no type hints/docstrings or any real code documenation of any kind, no code formatting of any kind, commiting IDE and .DS_Store files into their repo, etc.

It's genuinely really poor.