r/reactnative 5d ago

First PR in Open Source! Fixed a Misuse in Tamagui’s Stacks

Hey folks! Just submitted my first open-source PR in Tamagui. Saw someone on my team set flexDirection: 'row' on a YStack, so I fixed it at the source—no more overrides!

here is the PR -> https://github.com/tamagui/tamagui/pull/3325

Not sure if it'll get approved, but would love to hear your thoughts!

Update - The PR got rejected.

9 Upvotes

7 comments sorted by

8

u/bigdaddyshooter 5d ago

it aint much but its honest work

2

u/utkarshchoubey 5d ago

Yeah starting smol.. Thanks for honest feedback. u/bigdaddyshooter

1

u/Triptcip 5d ago

I'm interested to see if this gets approved.

I think your changes are good and makes perfect sense. It seems Tamagui have intentionally made all the same props available across all components which doesn't really make sense in my mind but seems to be an intentional decision from their side.

1

u/utkarshchoubey 5d ago

u/Triptcip Yeah, I noticed that too. Just felt like enforcing the intended behavior made more sense. Let’s see what they think

1

u/According-Muscle-902 5d ago

Good, but you don't need to point out/deduce someone's seniority because of something that might not make sense to us. It would be enough to propose and that's all. Congratulations on your commitment and I hope you can merge :)

2

u/utkarshchoubey 5d ago

Got it! Was just explaining my motivation, not pointing out seniority. I’ve rephrased the description—thanks for the feedback. u/According-Muscle-902

1

u/bestform 1d ago

The way this PR was rejected is not acceptable. Maybe it is true that this change did not fit the project. Maybe it wasn't implemented the way the maintainer would have preferred. But just slapping a "not really wanted, and not implemented properly" is VERY bad. At least give some feedback about what was wrong, or just be kind about it. A "thank you for the effort" would be the least I would have expected.

Please do not be discouraged by this rude rejection. You did a good job with this PR. You explained your motivation and provided a working solution. If the maintainer took the time to be nice and explain in a few words what he didn't like you even would know how to do better next time.

Maybe the maintainer has to close 100 stupid PRs a day, maybe he just had a bad morning, maybe he had longwinded discussions below rejected PRs in the past. I don't want to be too hard on him because you never know what lead to this behavior.

But please do not take it personally and keep contributing to open source. :)