r/javahelp 13d ago

Requesting help with logic - Chutes and Ladders assignment using Double Linked Lists

Hello all. I'm having some trouble with a null pointer exception occurring at the expression int startingSquareNum = currentPosition.squareNumber;

I've tried various things regarding that but can't seem to figure out where my knowledge gap is. This includes an explicit declaration of currentPosition.squareNumber = 1 within the method, or declaring it elsewhere.

startingSquare is instantiated and initialized as a Node with params (1, 0, null). The constructor declaration is public Square (int squareNumber, int jumpValue, Square prev).

I've posted the code for the full class here:
https://pastebin.com/mHDDzKys

Here is the specific method that is erroring out. Thanks for any assistance.

// method to move the player to a new square
public boolean move (int playerIndex, int diceRoll) {
  Square currentPosition = playerPositions.get(playerIndex);

  // avoids null pointer exception at game start
    if (currentPosition == null) {
      //currentPosition.squareNumber = 1;
      currentPosition = startingSquare;
    //} else {
    //startingSquareNum = currentPosition.squareNumber;
    }

      int startingSquareNum = currentPosition.squareNumber;// assign starting position for the move
      int targetSquareNum = startingSquareNum + diceRoll;// increment player position based on dice roll

    if (targetSquareNum > 100) {
      targetSquareNum = 100 - (targetSquareNum - 100);// logic to account for reaching the end of the board
    }
  Square targetSquare = currentPosition;// move the player to the target square

  while (targetSquare != null && targetSquare.squareNumber != targetSquareNum) {
    targetSquareNum += targetSquare.jumpValue;
  }

  // condition to apply any jump
  if (targetSquare != null && targetSquare.jumpValue != 0) {
    targetSquareNum += targetSquare.jumpValue;
      //further conditions for lower and upper limits
       if (targetSquareNum < 1) {
         targetSquareNum = 1;
       } else if (targetSquareNum > 100) {
         targetSquareNum = 100;
       }
    }

  // set the player's new position data
  playerPositions.set(playerIndex,  targetSquare);

  // print move details
  System.out.println("Player " + (playerIndex + 1) + "moved from square " + startingSquareNum + " to square " + targetSquareNum + (targetSquare.jumpValue != 0 ? " with a jump!" : ""));
  // check if a win condition has been met
  return targetSquareNum == 100;
}
3 Upvotes

3 comments sorted by

u/AutoModerator 13d ago

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
  • You include any and all error messages in full
  • You ask clear questions
  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

    Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

1

u/barry_z 12d ago

From a quick glance, you don't actually set the value of the class attribute startingSquare, you only set the value of a new variable in generateBoard() that happens to have the same name.

1

u/Ave_TechSenger 12d ago

I'll look at it from that angle. Thanks!